Open
Conversation
benITo47
force-pushed
the
@bo/yoloObjectDetection
branch
from
aec863e to
9b77da7
Compare
msluszniak
reviewed
Mar 23, 2026
...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp
Outdated
Show resolved
Hide resolved
…ject_detection/ObjectDetection.cpp
msluszniak
reviewed
Mar 23, 2026
...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp
Outdated
Show resolved
Hide resolved
…ject_detection/ObjectDetection.cpp
msluszniak
reviewed
Mar 23, 2026
Comment on lines
+136
to
+140
| * @example | ||
| * ```typescript | ||
| * const sizes = model.getAvailableInputSizes(); // [384, 512, 640] for YOLO models, or undefined for RF-DETR | ||
| * ``` | ||
| */ |
Member
There was a problem hiding this comment.
I'm wondering if we should keep this example here, no other typedocs have example section
Contributor
There was a problem hiding this comment.
I think the most important is to keep it consistent between modules, so I would prefer to remove it.
Comment on lines
+215
to
+221
| * @example | ||
| * ```typescript | ||
| * const detections = await model.forward('path/to/image.jpg', { | ||
| * detectionThreshold: 0.7, | ||
| * inputSize: 640, // For YOLO models | ||
| * classesOfInterest: ['PERSON', 'CAR'], | ||
| * }); |
Comment on lines
+37
to
+42
| | RF_DETR_NANO (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26N (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26S (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26M (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26L (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26X (XNNPACK FP32) | TBD | TBD | |
Comment on lines
+55
to
+60
| | RF_DETR_NANO (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26N (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26S (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26M (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26L (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26X (XNNPACK FP32) | TBD | TBD | |
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds yolo models and multi-method support to our ObjectDetection API.
Deduplication of common CV code will be done in a separate PR
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Try running example apps with Yolo models
Run tests
Screenshots
Related issues
Closes #718
Checklist
Additional notes